Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Print the optional Printable passed to stop ops #3886

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

nandor
Copy link
Contributor

@nandor nandor commented Feb 29, 2024

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • API modification
  • Bugfix

Desired Merge Strategy

  • Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

The message passed to stop is no longer ignored. The construct was extended to accept Printable.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Feature New feature, will be included in release notes label Feb 29, 2024
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of minor comments, and don't forget to run sbt fmt to run formatting.

@nandor nandor force-pushed the nandor/stop-print-msg branch from 404ca5a to 2fb0a15 Compare February 29, 2024 16:54
@jackkoenig jackkoenig added this to the 7.0 milestone Feb 29, 2024
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't mind adding back def apply(message: String)(implicit sourceInfo: SourceInfo): Stop, then we can backport this to 6.x and it's also probably better to overload rather than rely on the implicit conversion from String to Printable anyway.

@nandor nandor force-pushed the nandor/stop-print-msg branch from 2fb0a15 to 1b9c47c Compare February 29, 2024 17:44
@jackkoenig jackkoenig modified the milestones: 7.0, 6.x Feb 29, 2024
@jackkoenig jackkoenig enabled auto-merge (squash) February 29, 2024 17:45
@jackkoenig jackkoenig merged commit 109ee9e into chipsalliance:main Feb 29, 2024
14 checks passed
@mergify mergify bot added the Backported This PR has been backported label Feb 29, 2024
mergify bot pushed a commit that referenced this pull request Feb 29, 2024
chiselbot pushed a commit that referenced this pull request Mar 1, 2024
* Print an optional Printable passed to stop ops (#3886)

(cherry picked from commit 109ee9e)

* Resolve binary compatibility issues

---------

Co-authored-by: Nandor Licker <nandor.licker@sifive.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Backported This PR has been backported Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants