-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Print the optional Printable passed to stop ops #3886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple of minor comments, and don't forget to run sbt fmt
to run formatting.
404ca5a
to
2fb0a15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't mind adding back def apply(message: String)(implicit sourceInfo: SourceInfo): Stop
, then we can backport this to 6.x and it's also probably better to overload rather than rely on the implicit conversion from String to Printable anyway.
2fb0a15
to
1b9c47c
Compare
(cherry picked from commit 109ee9e)
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
The message passed to
stop
is no longer ignored. The construct was extended to accept Printable.Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.