Fix widths for literal values in Bundle literals (backport #4082) #4092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
added
the
Backport
github-actions
bot
added
the
Bugfix
jackkoenig
force-pushed
the
mergify/bp/6.x/pr-4082
branch
from
eee9420 to
a971c76
Compare
* Fix widths for literal values in Bundle literals Previously, the user-specified (or unspecified minimum width) of the literal would be used in some operations like concatenation. * Implicitly truncate too-wide literals in Bundle literals This is to fix a bug in concatenation without breaking things relying on implicit truncation. This will be a warning in newer versions of Chisel. (cherry picked from commit 3939e57)
Also move waivers from files to build.sbt.
jackkoenig
force-pushed
the
mergify/bp/6.x/pr-4082
branch
from
55184b4 to
ef7f748
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Previously, the user-specified (or unspecified minimum width) of the literal would be used in some operations like concatenation. For literal values that are too-wide, they will now truncate to the correct width. This will become a warning (then later an error) in newer major versions of Chisel.
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.This is an automatic backport of pull request #4082 done by [Mergify](https://mergify.com).