Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix 0 width signals chiselsim (backport #4100) #4103

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 28, 2024

Fixes #4099

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Fix failing ChiselSim/SVsim error to simulate modules with zero-width ports.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This is an automatic backport of pull request #4100 done by [Mergify](https://mergify.com).

(cherry picked from commit 2f9faa2)

# Conflicts:
#	src/test/scala/chiselTests/simulator/SimulatorSpec.scala
@github-actions github-actions bot added the Bugfix Fixes a bug, will be included in release notes label May 28, 2024
@jackkoenig jackkoenig added the Backport Automated backport, please consider for minor release label May 29, 2024
@jackkoenig jackkoenig force-pushed the mergify/bp/5.x/pr-4100 branch from d360097 to d65599a Compare May 29, 2024 17:37
@chiselbot chiselbot merged commit de4d945 into 5.x May 29, 2024
17 checks passed
@chiselbot chiselbot deleted the mergify/bp/5.x/pr-4100 branch May 29, 2024 17:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Backport Automated backport, please consider for minor release Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants