Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix BoringUtils for identity views (backport #4220) #4221

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 26, 2024

We should also support non-identity views, that involves creating more secret commands (e.g. materializing a wire). This is more of a patch fix that is made important because of #4198 which results in a lot more identity views (the return value of .asTypeOf).

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This is an automatic backport of pull request #4220 done by [Mergify](https://mergify.com).

@mergify mergify bot added the Backport Automated backport, please consider for minor release label Jun 26, 2024
@github-actions github-actions bot added the Bugfix Fixes a bug, will be included in release notes label Jun 26, 2024
@jackkoenig jackkoenig force-pushed the mergify/bp/6.x/pr-4220 branch from b089aab to e5b5708 Compare June 26, 2024 20:42
@chiselbot chiselbot merged commit 261ca7e into 6.x Jun 26, 2024
15 checks passed
@chiselbot chiselbot deleted the mergify/bp/6.x/pr-4220 branch June 26, 2024 20:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Backport Automated backport, please consider for minor release Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants