Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Select.attachedTo (backport #4458) #4461

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 10, 2024

Previously it would always fail to find anything.

Working on the Mill build, I was lazy in setting up scalacOptions and applied -Xlint:infer-any to everything which caught this. Unfortuantely, Iterable.contains is not type safe but if you screw up the type, this lint will catch it inferring Any (or Object).

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This is an automatic backport of pull request #4458 done by [Mergify](https://mergify.com).

Previously it would always fail to find anything.

(cherry picked from commit 1aa41cd)

# Conflicts:
#	src/main/scala/chisel3/aop/Select.scala
@mergify mergify bot added Backport Automated backport, please consider for minor release bp-conflict labels Oct 10, 2024
Copy link
Contributor Author

mergify bot commented Oct 10, 2024

Cherry-pick of 1aa41cd has failed:

On branch mergify/bp/6.x/pr-4458
Your branch is up to date with 'origin/6.x'.

You are currently cherry-picking commit 1aa41cdb7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/test/scala/chiselTests/aop/SelectSpec.scala

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/main/scala/chisel3/aop/Select.scala

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added the Bugfix Fixes a bug, will be included in release notes label Oct 10, 2024
@chiselbot chiselbot merged commit f11d9d1 into 6.x Nov 25, 2024
15 checks passed
@chiselbot chiselbot deleted the mergify/bp/6.x/pr-4458 branch November 25, 2024 21:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Backport Automated backport, please consider for minor release Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants