Bump to Chisel v3.3.0 and FIRRTL v1.3.0 #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
changed the title
|
This has been updated to RC3, it currently will fail the Wake compilation test because I need to update api-chisel3-sifive and api-firrtl-sifive, but the functionality should be correct. |
jackkoenig
force-pushed
the
chisel-3-3
branch
2 times, most recently
from
9e5ba63 to
de7456b
Compare
9 tasks
|
the two failign tests looked like transient maven issues so i kicked them off again |
jackkoenig
force-pushed
the
chisel-3-3
branch
2 times, most recently
from
60522fa to
9f5e3c4
Compare
jackkoenig
changed the title
hcook
approved these changes
May 1, 2020
|
Does this include the workaround chipsalliance/firrtl#1556? |
Not yet, I was thinking about copy-pasting the code here and then removing it on the next bump but I could also just try to get the fix in and backported and then we can bump along the stable branch, a bit past |
* Update some uses of @chiselName to disable new prefixing behavior * Update Stage/Phase dependencies to new Dependency instead of Class * Technically bumped to merge-base of each tag with their respective release branches: 3.3.x for chisel3 and 1.3.x for firrtl This better supports Wit dependencies * Include all chisel3 class files on FIRRTL run classpath * Bump api-chisel3-sifive to resolve Wit conflicts and bump api-scala-sifive to support Wit >= v0.13.0
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release branches: 3.3.x for chisel3 and 1.3.x for firrtl
This better supports Wit dependencies
We include chisel3 on the classpath for running FIRRTL because of use of utils like
chisel3.util.HasBlackBoxResource. chipsalliance/chisel#1384 broke up the chisel3 build into multiple directories so I had to update the Makefiles to include the extra directories.TODO Release Notes Highlights
Related issue:
Type of change: other enhancement
Impact: API modification
Development Phase: implementation
Release Notes
Bump to Chisel v3.3.0-RC3 and FIRRTL v1.3.0-RC3. Chisel and FIRRTL use a versioning scheme
X.Y.ZwhereYsignifies major version and thus may contain backwards incompatible API changes. See their respective release notes (currently in draft):https://github.com/freechipsproject/chisel3/releases
https://github.com/freechipsproject/firrtl/releases