-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
livereload #1
Comments
Whats involved in getting this in? |
Hmm, goooood questiooooon. I believe we're already injecting the script into the The fancier stuff would then be to also add hot reloading but that's just an extra plugin on top of this hmm |
I didn't see the live reload script last night when I tried the example. (#69 for some minor changes to that). I could be trippin |
Oh odd, seems it was removed in the latest patch. Ah well, could easily be restored C: https://github.com/yoshuawuyts/bankai/blob/0077f522b5d3ba0a1060c725c833f098e3749fbc/handler-html.js#L1 |
Actually the livereload script was never included. Is this worthwile given hmr could be implemented instead? |
yeah guess we could add hmr for |
I would rather see live reload if it means seeing it sooner than an HMR solution. I've not had great experiences with HMR in the past. It requires that you modify code to work with it right? |
@bcomnes nah in this case we would go for the naive option - save the state object globally; reload the |
What about people who want to use bankai for projects that don't have global state the same way choo/redux style apps do? Just browserify built apps. They'd probably need live reload. |
Boils down to: What is this? A beefy/budo clone or something more specialized? My view of bankai
|
I think you're both right. The way I view
Does that make sense? |
closing in favor of #31 |
Hooks are already in place in html, should probably add to sheetify hooks to send a msg when updated
The text was updated successfully, but these errors were encountered: