One more fix for the create bank with fill - don't crash when no patch matches the current filter.

Author: christofmuc

The-Orm/PatchView.cpp

@@ -1096,7 +1096,13 @@ void PatchView::fillList(std::shared_ptr<midikraft::PatchList> list, CreateListD
 				return;
 			}
 		}
-		if (fillParameters.fillMode == CreateListDialog::TListFillMode::Top) {
+
+        if(database_.getPatchesCount(currentFilter()) == 0) {
+            spdlog::error("The list can't be filled, there are no patches in the database matching the current filter.");
+            return;
+        }
+
+        if (fillParameters.fillMode == CreateListDialog::TListFillMode::Top) {
 			loadPage(0, (int) patchesDesired, filter, [list, finishedCallback, minimumPatches](std::vector<midikraft::PatchHolder> patches) {
 				// Check if we need to extend the patches list to make sure we have enough patches to make a full bank
 				while (patches.size() < minimumPatches) {

release_notes/2.4.3.md

@@ -15,4 +15,5 @@ Fixed by just repeating the last entry to make sure the entire bank is full.
 * Fixed \#354: Deleted user banks are still visible in the UI but gone after restart
 * Fixed \#352: The accidental jump back to page 1 on editing a category. This was a regression but introduced with \#310 back in April 2024 with the release of 2.3.0
 * Fixed \#353: Renaming a patch would not set the patch to dirty in the synth bank, and therefore sending the changed bank to the synth
-did not update that patch, failing to change the name in the synth. There is more to this issue, but the main problem is fixed.
+did not update that patch, failing to change the name in the synth. There is more to this issue, but the main problem is fixed.
+* One more fix for the create bank with fill - don't crash when no patch matches the current filter. Thanks to @salzaverde!