Implementing the Korg MS2000, hopefully this device finally works now. Also, add a guard in that the implementation of the method renamtePatch() is optional, and it will be ignored if the method is not implemented.

Author: christofmuc

adaptions/BundledAdaptation.cpp

@@ -19,6 +19,7 @@ namespace knobkraft {
 			{ "DSI Prophet 12", "DSI_Prophet_12", std::string(DSI_Prophet_12_py, DSI_Prophet_12_py + DSI_Prophet_12_py_size) },
 			//{ "Korg DW-8000 Adaption", "Korg_DW_8000_Adaption", std::string(KorgDW8000_py, KorgDW8000_py + KorgDW8000_py_size ) },
 			{ "Korg DW-6000", "Korg_DW_6000", std::string(KorgDW6000_py, KorgDW6000_py + KorgDW6000_py_size) },
+			{ "Korg MS2000", "Korg_MS2000", std::string(KorgMS2000_py, KorgMS2000_py + KorgMS2000_py_size) },
 			{ "Matrix 6", "Matrix_6", std::string(Matrix_6_py, Matrix_6_py + Matrix_6_py_size) },
 			{ "Matrix 1000 Adaption", "Matrix_1000", std::string(Matrix1000_py, Matrix1000_py + Matrix1000_py_size) },
 			{ "Pioneer Toraiz AS1", "Pioneer_Toraiz_AS1", std::string(PioneerToraiz_AS1_py, PioneerToraiz_AS1_py + PioneerToraiz_AS1_py_size) },

adaptions/GenericAdaptation.cpp

@@ -61,6 +61,14 @@ namespace knobkraft {
 			patchNumber_ = std::make_shared<GenericPatchNumber>(MidiProgramNumber::fromZeroBase(0));
 		}
 
+		bool pythonModuleHasFunction(std::string const &functionName) {
+			ScopedLock lock(GenericAdaptation::multiThreadGuard);
+			if (!adaptation_) {
+				return false;
+			}
+			return py::hasattr(*adaptation_, functionName.c_str());
+		}
+
 		template <typename ... Args>
 		py::object callMethod(std::string const &methodName, Args& ... args) const {
 			ScopedLock lock(GenericAdaptation::multiThreadGuard);
@@ -119,6 +127,10 @@ namespace knobkraft {
 		}
 
 		void setName(std::string const &name) override {
+			// set name is an optional method - if it is not implemented, the name in the patch is never changed, the name displayed in the Librarian is
+			if (!pythonModuleHasFunction("renamePatch")) return;
+
+			// Very well, then try to change the name in the patch data
 			try {
 				ScopedLock lock(GenericAdaptation::multiThreadGuard);
 				std::vector<int> v(data().data(), data().data() + data().size());