<!DOCTYPE html> is stripped out #20

nemtsov · 2016-12-17T16:48:42Z

From examples/generic-simple:

input:

<!DOCTYPE html>
<html>
  <head>
    <title>Generic &amp; Simple Prerendering Demo</title>
  </head>
  <body>
    <input id="new-todo" placeholder="New todo">
    <div id="todos"></div>
    <script src="main.js"></script>
  </body>
</html>

output:

<html><head>
    <title>Generic &amp; Simple Prerendering Demo</title>
  </head>
  <body>
    <input id="new-todo" placeholder="New todo">
    <div id="todos"><ul><li class="item">Do the dishes <button class="remove-todo" data-index="0">X</button></li><li class="item">Make the bed <button class="remove-todo" data-index="1">X</button></li><li class="item">Take out the trash <button class="remove-todo" data-index="2">X</button></li></ul></div>
    <script src="main.js"></script>
  

</body></html>

Note that the <!DOCTYPE html> is stripped out.
It is important that the doctype is preserved, as it affects page rendering.

The text was updated successfully, but these errors were encountered:

qgustavor · 2016-12-17T17:58:38Z

I was just going to post this issue, but I'm one hour delayed... Seems the problem is on this line: return document.documentElement.outerHTML. Isn't hard to get the doctype and fix that.

Edit: how about this? (I just tested here, it's working)

var html = page.evaluate(function () {
  const doctype = new XMLSerializer().serializeToString(document.doctype)
  const outerHTML = document.documentElement.outerHTML
  return doctype + outerHTML
})

chrisvfritz · 2016-12-23T21:49:56Z

Good catch! I'll add this fix as soon as I can given the holidays.

chrisvfritz · 2016-12-24T05:09:15Z

Fixed in the 2.0 release. 🎉

nemtsov changed the title ~~<!doctype html> is stripped out~~ <!DOCTYPE html> is stripped out Dec 17, 2016

chrisvfritz added the bug label Dec 23, 2016

chrisvfritz closed this as completed Dec 24, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

<!DOCTYPE html> is stripped out #20

<!DOCTYPE html> is stripped out #20

nemtsov commented Dec 17, 2016

qgustavor commented Dec 17, 2016 •

edited

Loading

chrisvfritz commented Dec 23, 2016

chrisvfritz commented Dec 24, 2016

<!DOCTYPE html> is stripped out #20

<!DOCTYPE html> is stripped out #20

Comments

nemtsov commented Dec 17, 2016

qgustavor commented Dec 17, 2016 • edited Loading

chrisvfritz commented Dec 23, 2016

chrisvfritz commented Dec 24, 2016

qgustavor commented Dec 17, 2016 •

edited

Loading