Skip to content

Commit ff86c68

Browse files
cirocostak8s-ci-robot
authored andcommittedJan 14, 2019
[stable/concourse] Moves prometheus annotation to deployment (helm#9536)
Previously, Prometheus annotations were added to the web service, which is meant to represent the whole replica set of pods, leaving no pod-specific labels to the metrics gathered, defeating the purpose of some of them (that are meant to be container-specific). By moving them to `deployment`, we're able to collect them per-pod, instead of per-service. Signed-off-by: Ciro S. Costa <cscosta@pivotal.io>
1 parent 35c9af9 commit ff86c68

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed
 

‎stable/concourse/Chart.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: concourse
2-
version: 3.4.0
2+
version: 3.4.1
33
appVersion: 4.2.2
44
description: Concourse is a simple and scalable CI system.
55
icon: https://avatars1.githubusercontent.com/u/7809479

‎stable/concourse/templates/web-deployment.yaml

+7-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,13 @@ spec:
1515
app: {{ template "concourse.web.fullname" . }}
1616
release: "{{ .Release.Name }}"
1717
annotations:
18-
{{ toYaml .Values.web.annotations | indent 8 }}
18+
{{- if .Values.concourse.web.prometheus.enabled }}
19+
prometheus.io/scrape: "true"
20+
prometheus.io/port: {{ .Values.concourse.web.prometheus.bindPort | quote }}
21+
{{- end }}
22+
{{- range $key, $value := .Values.web.annotations }}
23+
{{ $key }}: {{ $value | quote }}
24+
{{- end }}
1925
spec:
2026
{{- with .Values.web.nodeSelector }}
2127
nodeSelector:

‎stable/concourse/templates/web-svc.yaml

+1-7
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,7 @@ metadata:
88
release: "{{ .Release.Name }}"
99
heritage: "{{ .Release.Service }}"
1010
annotations:
11-
{{- range $key, $value := .Values.web.service.annotations }}
12-
{{ $key }}: {{ $value | quote }}
13-
{{- end }}
14-
{{- if .Values.concourse.web.prometheus.enabled }}
15-
prometheus.io/scrape: "true"
16-
prometheus.io/port: {{ .Values.concourse.web.prometheus.bindPort | quote }}
17-
{{- end }}
11+
{{ toYaml .Values.web.service.annotations | indent 4 }}
1812
spec:
1913
type: {{ .Values.web.service.type }}
2014
{{ if .Values.web.service.loadBalancerSourceRanges }}

0 commit comments

Comments
 (0)
Please sign in to comment.