Increase matrix of supported Android CLT and Java versions

[bartekpacia]

resolve #73

discovered during process of working on this PR - cirruslabs/cirrus-ci-docs#1288

[bartekpacia]

Ughhh... what? :(

@fkorotkov @edigaryev

[fkorotkov]

@bartekpacia sorry about that. Unblocked your account. Your first iteration looked too suspicious to our crypto mining detection mechanism.

[edigaryev]

Do I understand correctly that this won't produce any new container images and/or tags? Is this intended?

[bartekpacia]

This is still WIP, sorry!

[bartekpacia]

@fkorotkov Smoke Test is failing. I guess it's because it tries to build sdk/tools/Dockerfile, which now requries 2 arguments, but those args aren't provided. How can I provide those 2 args to the implicit docker_builder building that image?

[edigaryev]

How can I provide those 2 args to the implicit docker_builder building that image?

Docker ARG's instruction can accept default values.

[bartekpacia]

@edigaryev @fkorotkov I think I got tools Dockerfile matrix done. Now, how should I go about making 34 and 34-ndk dockerfile also have that matrix?

Do I need to create new directories for each combination?

Or, should I parametrize the FROM instruction here:

docker-images-android/sdk/34/Dockerfile

Line 1 in 9e83bc2

FROM ghcr.io/cirruslabs/android-sdk:tools

to be like this:

ARG jdk_version=17

FROM ghcr.io/cirruslabs/android-sdk:tools-${jdk_version}

[bartekpacia]

ping @fkorotkov :)

[fkorotkov]

Should we do the same for ghcr.io/cirruslabs/android-sdk? Have variants for it's FROM?

[bartekpacia]

@fkorotkov I'm not sure. Your call!

The end result I'd like to see is to have each of the 3 different images in this repo (tools, 34, and 34-ndk), to have 4 JDK version variants.

So that'd give 12 images per release (3 images * 4 variants).

[fkorotkov]

I think we need to add the arguments to sdk/34/Dockerfile too. Lastly to preserve backward compatibility ghcr.io/cirruslabs/android-sdk:tools-jdk17 should be tagged as ghcr.io/cirruslabs/android-sdk:tools-jdk17. Alternatively I don't mind if we'll just build ghcr.io/cirruslabs/android-sdk:tools with the defaults from the arguments.

[bartekpacia]

@fkorotkov Gotcha. Please see my latest commit, I hope I got it right.

Re: Java version - I think that latest JDK LTS should be the default. See #71. That said I'm OK with leaving openjdk17 as default.

[bartekpacia]

Hm, it looks like we're hitting this problem: docker buildx fails to show result in image list

The answer suggests to add --output type=docker argument, but then we hit docker/buildx#59

[bartekpacia]

ping @fkorotkov, any ideas here?