This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the docker portions of pca-report-library #10
base: develop
Are you sure you want to change the base?
Add the docker portions of pca-report-library #10
Changes from 19 commits
89145e2
8bddd3b
c0c141d
e52afdb
5146fa9
f496a40
fc68801
49c27b1
8cc7e86
2f60a6e
7eb548c
35aade2
0ce564c
1527721
8eb36c5
f6a68ff
c62293b
825d6e1
d723194
b650f78
d45b1c1
2030740
b2ce069
c8f5a55
4764d7d
0df5d73
f85cb89
b6631f2
fc03e8e
1275338
dad82c5
307f24c
8b4a5ab
8d9ac4a
598acee
af48f3c
ea18e21
a8f6a04
933aa56
f9ed352
079d2e9
7cbc7c7
91c7b63
74e995f
2b0eba1
4ef3793
a9238ed
3095f9c
f8c135f
c15795b
1be4e84
9d72a51
cf1db91
b7a940d
2f9cd7a
c718294
7286a3c
4d038c2
cfb0e95
642ef11
b4f38da
c56cbe2
ebc3182
a9e9a3e
eb3bd0c
02a0524
64810e1
19beb67
120e86b
c494107
2408f6a
2cd9701
eed0469
081047b
4be5029
2f7a076
8d3e8fb
4df844d
a9c92b2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the recent items that I noted have made me realize that this repo should really be called
pca-report-library-docker
, since it containerizespca-report-library
. Let's take care of that name change (and the related changes to theREADME
) as the final step after all of the other conversations in this PR have been resolved.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dav3r okay- please let me know when and how to take care of this or if you will
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dav3r when you are back from vacation, please let me know if everything else has been resolved and then how to take care of the repo name change, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do @ameliav - I am going try to get back to you on this tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repo name change is pretty simple- I'm thinking we should change the repo name as soon as this PR is merged. I can take care of the renaming. In the meantime, you should update the README and change anything that says
pca-report-generator-docker
topca-report-library-docker
.In addition to that, you still have to get the failing tests to pass. Let me know if you need any help there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dav3r thanks for getting back. I've been assigned to another task so this has been put on hold for me. Will comment again when I'm able to work on this again.