Upgrade base Docker image #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
bug
mcdonnnj
approved these changes
Sep 12, 2022
jsf9k
force-pushed
the
improvement/upgrade-base-docker-image
branch
from
825302f to
6d823f8
Compare
jsf9k
added a commit
to cisagov/skeleton-docker
that referenced
this pull request
Sep 13, 2022
We saw in cisagov/postfix-docker#47 that the sed commands in the bump_version.sh script could inadvertently match the CC0 version in the README.md file. This change escapes the periods in the version before passing it on to sed so that they only match periods and not just any character.
6 tasks
jsf9k
added a commit
to cisagov/skeleton-packer
that referenced
this pull request
Sep 13, 2022
We saw in cisagov/postfix-docker#47 that the sed commands in the bump_version.sh script could inadvertently match the CC0 version in the README.md file. This change escapes the periods in the version before passing it on to sed so that they only match periods and not just any character.
6 tasks
jsf9k
added a commit
to cisagov/skeleton-aws-lambda
that referenced
this pull request
Sep 13, 2022
We saw in cisagov/postfix-docker#47 that the sed commands in the bump_version.sh script could inadvertently match the CC0 version in the README.md file. This change escapes the periods in the version before passing it on to sed so that they only match periods and not just any character.
6 tasks
jsf9k
added a commit
to cisagov/skeleton-python-library
that referenced
this pull request
Sep 13, 2022
We saw in cisagov/postfix-docker#47 that the sed commands in the bump_version.sh script could inadvertently match the CC0 version in the README.md file. This change escapes the periods in the version before passing it on to sed so that they only match periods and not just any character.
6 tasks
mcdonnnj
pushed a commit
to cisagov/skeleton-packer
that referenced
this pull request
Nov 14, 2022
We saw in cisagov/postfix-docker#47 that the sed commands in the bump_version.sh script could inadvertently match the CC0 version in the README.md file. This change escapes the periods in the version before passing it on to sed so that they only match periods and not just any character.
jsf9k
added a commit
to cisagov/kali-packer
that referenced
this pull request
Nov 16, 2022
We saw in cisagov/postfix-docker#47 that the sed commands in the bump_version.sh script could inadvertently match the CC0 version in the README.md file. This change escapes the periods in the version before passing it on to sed so that they only match periods and not just any character.
mcdonnnj
pushed a commit
to cisagov/skeleton-docker
that referenced
this pull request
Nov 21, 2022
We saw in cisagov/postfix-docker#47 that the sed commands in the bump_version.sh script could inadvertently match the CC0 version in the README.md file. This change escapes the periods in the version before passing it on to sed so that they only match periods and not just any character.
mcdonnnj
pushed a commit
to cisagov/skeleton-python-library
that referenced
this pull request
Jan 7, 2023
We saw in cisagov/postfix-docker#47 that the sed commands in the bump_version.sh script could inadvertently match the CC0 version in the README.md file. This change escapes the periods in the version before passing it on to sed so that they only match periods and not just any character.
king-alexander
pushed a commit
to cisagov/admiral
that referenced
this pull request
Jan 12, 2023
We saw in cisagov/postfix-docker#47 that the sed commands in the bump_version.sh script could inadvertently match the CC0 version in the README.md file. This change escapes the periods in the version before passing it on to sed so that they only match periods and not just any character.
Sallenmoore
pushed a commit
to Sallenmoore/foundryvtt-docker
that referenced
this pull request
Jun 18, 2023
We saw in cisagov/postfix-docker#47 that the sed commands in the bump_version.sh script could inadvertently match the CC0 version in the README.md file. This change escapes the periods in the version before passing it on to sed so that they only match periods and not just any character.
mcdonnnj
added a commit
to cisagov/pre-commit-packer
that referenced
this pull request
Sep 26, 2024
We saw in cisagov/postfix-docker#47 that the sed commands in the bump_version.sh script could inadvertently match the CC0 version in the README.md file. This change escapes the periods in the version before passing it on to sed so that they only match periods and not just any character. Co-authored-by: Shane Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request upgrades the base Docker image on which this one is based.
💭 Motivation and context
The old Debian Buster Docker images do no support all the hardware platforms that we want to support. This has caused this project's builds to fail recently.
🧪 Testing
All automated testing passes.
✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist