Fixed ordering of setters so that user event handlers override defaults #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -118,7 +118,7 @@ setItemProps | |||
| . Int | |||
| -> Array (HP.IProp (ItemProps p) (Query o item Unit)) | |||
| -> Array (HP.IProp (ItemProps p) (Query o item Unit)) | |||
| setItemProps index = flip (<>) | |||
| setItemProps index = (<>) | |||
There was a problem hiding this comment.
could just be append
There was a problem hiding this comment.
True...but actually more verbose lol
|
I knew something was up! |
thomashoneyman
approved these changes
Jan 3, 2019
|
@linearray I'm assuming this is related to your issue in Slack. Glad @davezuch saw the cause of the problem. |
|
Thank you for the quick fix! |
crcornwell
approved these changes
Jan 3, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Turns out the last
IPropfor an event handler wins. The reason we thought otherwise is that our lovelyappendIPropsfunction in Ocelot reverses the order of the props. But anyone not using Ocelot, or at leastappendIProps, will not be able to override the default props here.Other Notes:
I have a corresponding branch in Ocelot that fixes
appendIProps. Once this PR is approved and a new release tagged, I'll make a PR there as well.