Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

it with assignment #20

Closed
thisredone opened this issue Jul 1, 2019 · 1 comment · Fixed by #21
Closed

it with assignment #20

thisredone opened this issue Jul 1, 2019 · 1 comment · Fixed by #21
Labels
good first issue Probably good for a user's first contribution. type: bug Something isn't working as intended or expected.

Comments

@thisredone
Copy link

Is something like this not possible?

foo.forEach(it.bar = true)

The output of that is:

foo.forEach(
  (_it2.bar = _it2 => {
    return true
  })
)

Which produces an error.

I was expecting it to compile into this:

foo.forEach(_it2 => {
  return _it2.bar = true
})
@haltcase
Copy link
Owner

haltcase commented Jul 4, 2019

Hey @thisredone, this is probably an unwanted side effect of the top-level assignment handling. I don't think there are any cases where the current output is desired so this should be fixed.

@haltcase haltcase added good first issue Probably good for a user's first contribution. type: bug Something isn't working as intended or expected. labels Jul 4, 2019
@haltcase haltcase added the status: in progress Work has started to close the issue. label Jul 11, 2019
@haltcase haltcase added status: pending release Issue is resolved but waiting to be released. and removed status: in progress Work has started to close the issue. status: pending release Issue is resolved but waiting to be released. labels Jul 11, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Probably good for a user's first contribution. type: bug Something isn't working as intended or expected.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants