-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use build
PEP 517 build frontend to build the package
#1303
Conversation
80a51b7
to
845ef26
Compare
05a6c32
to
85c5ab3
Compare
85c5ab3
to
1dc3bb4
Compare
33911f5
to
46b0c70
Compare
I'm curious what you think of this approach @henryiii, and whether this is something Nox should support upstream. |
This seems fine, and I've been considering the proper way to do this upstream; though what I want to do there is to integrate with needs, so sessions could request and install the produced files. Not really related, but nox-poetry should be able to use the new plugin support, too, by adding this to the top of a user's noxfile: /// script
dependencies = ["nox", "nox-poetry"]
/// |
Oh, also, picking the output name out is potentially a bit fragile; wouldn't it be better to use build's API? https://build.pypa.io/en/stable/api.html#build.ProjectBuilder.build |
That was the initial approach (1dc3bb4) but there were some problems with it:
Footnotes |
Changes in this PR
Require/test Poetry 1.7+Related