From d5e7d5c035d52a26404fc40cb4ade007036df040 Mon Sep 17 00:00:00 2001 From: Aleksander Nowodzinski Date: Tue, 7 Nov 2017 17:18:20 +0100 Subject: [PATCH 1/2] Migrated UI components from SASS to PostCSS. Added theme support. --- src/code.js | 2 +- theme/code.css | 4 ++++ theme/code.scss | 14 -------------- 3 files changed, 5 insertions(+), 15 deletions(-) create mode 100644 theme/code.css delete mode 100644 theme/code.scss diff --git a/src/code.js b/src/code.js index ad0d0ff..120518b 100644 --- a/src/code.js +++ b/src/code.js @@ -12,7 +12,7 @@ import CodeEngine from './codeengine'; import ButtonView from '@ckeditor/ckeditor5-ui/src/button/buttonview'; import codeIcon from '../theme/icons/code.svg'; -import '../theme/code.scss'; +import '../theme/code.css'; /** * The code feature. It introduces the Code button. diff --git a/theme/code.css b/theme/code.css new file mode 100644 index 0000000..b4ad378 --- /dev/null +++ b/theme/code.css @@ -0,0 +1,4 @@ +/* + * Copyright (c) 2003-2017, CKSource - Frederico Knabben. All rights reserved. + * For licensing, see LICENSE.md. + */ diff --git a/theme/code.scss b/theme/code.scss deleted file mode 100644 index a51de58..0000000 --- a/theme/code.scss +++ /dev/null @@ -1,14 +0,0 @@ -// Copyright (c) 2003-2017, CKSource - Frederico Knabben. All rights reserved. -// For licensing, see LICENSE.md or http://ckeditor.com/license - -@import '~@ckeditor/ckeditor5-theme-lark/theme/helpers/_colors.scss'; -@import '~@ckeditor/ckeditor5-theme-lark/theme/helpers/_rounded.scss'; -@import '~@ckeditor/ckeditor5-theme-lark/theme/helpers/_spacing.scss'; - -@include ck-color-add( ( 'code': rgba( 200, 200, 200, 0.3 ) ) ); - -code { - background-color: ck-color( 'code' ); - padding: ck-spacing( 'tiny' ); - border-radius: $ck-border-radius; -} From 6ea403435fe0e3d2ce1f7015b9f99c5cc9c83c2a Mon Sep 17 00:00:00 2001 From: Aleksander Nowodzinski Date: Wed, 22 Nov 2017 14:57:19 +0100 Subject: [PATCH 2/2] Added an info comment in the empty code styles sheet. --- theme/code.css | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/theme/code.css b/theme/code.css index b4ad378..3ebbb9b 100644 --- a/theme/code.css +++ b/theme/code.css @@ -2,3 +2,9 @@ * Copyright (c) 2003-2017, CKSource - Frederico Knabben. All rights reserved. * For licensing, see LICENSE.md. */ + +/* + * Note: This file should contain the wireframe styles only. But since there are no such styles, + * it acts as a message to the builder telling that it should look for the corresponding styles + * **in the theme** when compiling the editor. + */