Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Schema#getLimitElement() does not work for multi-ranges selection #4262

Closed
pomek opened this issue Feb 5, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1276
Closed

Schema#getLimitElement() does not work for multi-ranges selection #4262

pomek opened this issue Feb 5, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1276
Assignees
@pomek
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 14

Comments

@pomek
Copy link
Member

pomek commented Feb 5, 2018

Schema#getLimitElement() returns null for multi-ranges selection if one of them has the root element as the limit element.

That's the reason why the editor crashes in some cases on Firefox (#678).
@pomek pomek self-assigned this Feb 5, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-engine Feb 9, 2018
@Reinmar
Merge pull request #1276 from ckeditor/t/1275
050a415 
Fix: `Schema#getLimitElement()` will return a proper limit element (the root element) if one of the selection's ranges have the root element as the limit element. Closes #1275.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@pomek pomek mentioned this issue Oct 11, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@pomek pomek

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

Schema#getLimitElement() will work with multi-ranges selection ckeditor/ckeditor5-engine
2 participants
@pomek @mlewand