Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Usage of writer in _normalizeToElementConfig #4280

Closed
pjasiun opened this issue Feb 16, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1302
Closed

Usage of writer in _normalizeToElementConfig #4280

pjasiun opened this issue Feb 16, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1302
Assignees
@scofalik
Labels
package:engine
Milestone
iteration 14

Comments

@pjasiun
Copy link

pjasiun commented Feb 16, 2018

_normalizeToElementConfig method should use writer to create view elements. Is should be changed after https://github.com/ckeditor/ckeditor5-engine/issues/1294.
@pjasiun pjasiun assigned szymonkups and scofalik and unassigned szymonkups Feb 16, 2018
pjasiun referenced this issue in ckeditor/ckeditor5-engine Feb 19, 2018
Merge pull request #1302 from ckeditor/t/1295
809ea24 
Other: Introduced several improvements to conversion helpers. Closes #1295. Closes #1293. Closes #1292. Closes #1291. Closes #1290. Closes #1305.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@scofalik scofalik

Labels
package:engine
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

T/1295 Further improvements to conversion helpers ckeditor/ckeditor5-engine
4 participants
@pjasiun @scofalik @szymonkups @mlewand