Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[FF] Caret is rendered before a <br> despite the model selection being after it #4363

Closed
Reinmar opened this issue Jun 19, 2018 · 2 comments · Fixed by ckeditor/ckeditor5-engine#1582
Closed

[FF] Caret is rendered before a <br> despite the model selection being after it #4363

Reinmar opened this issue Jun 19, 2018 · 2 comments · Fixed by ckeditor/ckeditor5-engine#1582
Assignees
@oleq
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 21

Comments

@Reinmar
Copy link
Member

Reinmar commented Jun 19, 2018

It's Firefox only ;/

  1. Clear all content.
  2. Type "foo".
  3. Press Shift+Enter. New line appears but caret isn't moved anywhere.
  4. Type sth. The text appears in the new line (as if the selection was there).

jun-19-2018 14-52-09
@Reinmar
Copy link
Member Author

Reinmar commented Jun 19, 2018

FFS... this is FF's bug because we set the selection in the right place:

image

And I think I know it already. It's super old...

@Reinmar
Copy link
Member Author

Reinmar commented Jun 19, 2018

I'm postponing this to the next iteration. We need a workaround for this Firefox's issue. We should also find bugs on FF's side and ping its developers.

oleq referenced this issue in ckeditor/ckeditor5-engine Oct 18, 2018
@oleq
Tests: Added manual test for #1439.
1322d90
Reinmar referenced this issue in ckeditor/ckeditor5-utils Oct 24, 2018
@Reinmar
Merge pull request #254 from ckeditor/t/ckeditor5-engine/1439
53b7c94 
Feature: Implemented `env#isGecko()`. See ckeditor/ckeditor5-engine#1439.
Reinmar referenced this issue in ckeditor/ckeditor5-engine Oct 26, 2018
@Reinmar
Merge pull request #1582 from ckeditor/t/1439
80392ad 
Fix: Firefox should visually move the caret to the new line after a soft break. Closes #1439.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 21 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
This was referenced Oct 11, 2019
Merged
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@oleq oleq

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 21
3 participants
@Reinmar @oleq @mlewand