Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

$marker element should be allowed everywhere #4495

Closed
oskarwrobel opened this issue Mar 15, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1698
Closed

$marker element should be allowed everywhere #4495

oskarwrobel opened this issue Mar 15, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1698
Assignees
Milestone

Comments

@oskarwrobel
Copy link
Contributor

Model $marker is a temporary element created in the conversion process that helps setting markers from the input data to the Model#markers collection. Currently, this element is allowed only inside a $block and $root elements. It causes an issue with disappearing marker while setting data to the editor with a marker inside a table cell. Since $marker element is only a temporary element it should be allowed everywhere because a marker range does not have any limitations as long as is inside a $root bounds.

@oskarwrobel oskarwrobel self-assigned this Mar 15, 2019
scofalik referenced this issue in ckeditor/ckeditor5-engine Mar 15, 2019
Fix: Markers should be now correctly upcasted inside any element. Closes #1697.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 23 milestone Oct 9, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants