This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Schema#getLimitElement() will work with multi-ranges selection
#1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomek
force-pushed
the
t/1275
branch
2 times, most recently
from
5d1f398 to
100a327
Compare
added 3 commits
February 8, 2018 13:25
…if one of them has the root as the limit element.
|
Wouldn't this work: return element.getCommonAncestor( range.getCommonAncestor(), { includeSelf: true } );(I added the options param there) All tests pass. |
|
Thx. Fixed. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix:
Schema#getLimitElement()will return a proper limit element (the root element) if one of the selection's ranges have the root element as the limit element. Closes ckeditor/ckeditor5#4262.