This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
t/ckeditor5/1005: Implemented a module exposing the CKEDIOR_VERSION to the global scope
#249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjasiun
approved these changes
Jul 6, 2018
Reinmar
reviewed
Jul 10, 2018
src/version.js
Outdated
| * This error is thrown when the base {@link module:core/editor/editor~Editor `Editor`} | ||
| * class has been loaded twice (or more), a result of either: | ||
| * | ||
| * * the build containing two (or more) different versions of the {@link module:core/editor/editor~Editor `Editor`} |
There was a problem hiding this comment.
This sounds like this error occurs when you load ClassicEditor and InlineEditor together. It'd be good to keep it oriented on duplicating packages. It may be easier to understand. Duplicated Editor class is just a result of that.
There was a problem hiding this comment.
We could also give recipies how to solve this:
- Run
rm -rf node_modules && npm ifirst. - Check whether you're using up to date versions of all CKEditor 5 packages.
npm@5+is known for installing packages in a non-optimal, non-deduped way. You may try downgrading npm to version 4.
pomek
reviewed
Jul 10, 2018
package.json
Outdated
| @@ -8,6 +8,9 @@ | |||
| "ckeditor 5", | |||
| "ckeditor5-lib" | |||
| ], | |||
| "dependencies": { | |||
| "ckeditor5": "^10.1.0" | |||
There was a problem hiding this comment.
Something is broken here (indentation).
|
I'll fix mentioned issues. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Implemented a module exposing the
CKEDIOR_VERSIONto the global scope. Closes ckeditor/ckeditor5#1005.Additional information
Moved from ckeditor5 (ckeditor/ckeditor5#1140 (comment)).