-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Should we switch our builds to Terser? #1353
Comments
OK, it seems that webpack 4 may switch to terser as well because they consider this a non-breaking change: |
So after the webpack changes the minifier it might be a good moment to change it too. Maybe terser isn't the best and most stable, but it's actively maintained. - see e.g. the terser/terser#165. |
As I wrote in webpack/webpack#8350 (comment), I'm not worried about today. I'm worried what will be next year :D |
It's high time to finally move to terser. Lots of docs to update because we have plenty of |
Docs: Replaced UglifyJS with Terser. See #1353.
Other: Replaced UglifyJS with Terser. See ckeditor/ckeditor5#1353.
Other: Replaced UglifyJS with Terser. See ckeditor/ckeditor5#1353.
Other: Replaced UglifyJS with Terser. See ckeditor/ckeditor5#1353.
Other: Replaced UglifyJS with Terser. See ckeditor/ckeditor5#1353.
Other: Replaced UglifyJS with Terser. See ckeditor/ckeditor5#1353.
Followup to review the docs in #5836. |
Other: Replaced UglifyJS with Terser. See ckeditor/ckeditor5#1353.
Webpack 4 switched to
uglify-es
but according to mishoo/UglifyJS#3156 (comment)uglify-es
is dead:Looking at the links leading to mishoo/UglifyJS#3156 everyone is switching to Terser now. Webpack 5 will use Terser as well.
Question – when should we do the transition ourselves? Should we wait for webpack 5 or do that before it?
One thing to consider would be – is Terser ready? According to some comments it's not particularly stable yet. Also, looking at how frequently this changes... I'm afraid that before webpack 5 will be released they'll change the decision again to something else (while this is meant to be a joke, I'd like to understand what's the background behind big players switching to Terser so suddenly).
The text was updated successfully, but these errors were encountered: