Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Should we switch our builds to Terser? #1353

Closed
Reinmar opened this issue Nov 12, 2018 · 5 comments
Closed

Should we switch our builds to Terser? #1353

Reinmar opened this issue Nov 12, 2018 · 5 comments
Assignees
Labels
status:discussion type:docs This issue reports a task related to documentation (e.g. an idea for a guide). type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@Reinmar
Copy link
Member

Reinmar commented Nov 12, 2018

Webpack 4 switched to uglify-es but according to mishoo/UglifyJS#3156 (comment) uglify-es is dead:

so it seems strange to abandon it. Since you haven't deprecated it on NPM, should I assume you're only taking a break from maintaining it?

uglify-es has been forked and the new project is called terser. For projects that need ES6 support, use it instead of uglify-es, since all new development will be happening over there (and things like webpack are switching over to it shortly too):
https://github.com/fabiosantoscode/terser

Looking at the links leading to mishoo/UglifyJS#3156 everyone is switching to Terser now. Webpack 5 will use Terser as well.

Question – when should we do the transition ourselves? Should we wait for webpack 5 or do that before it?

One thing to consider would be – is Terser ready? According to some comments it's not particularly stable yet. Also, looking at how frequently this changes... I'm afraid that before webpack 5 will be released they'll change the decision again to something else (while this is meant to be a joke, I'd like to understand what's the background behind big players switching to Terser so suddenly).

@Reinmar Reinmar added status:discussion type:task This issue reports a chore (non-production change) and other types of "todos". type:docs This issue reports a task related to documentation (e.g. an idea for a guide). labels Nov 12, 2018
@Reinmar Reinmar added this to the next milestone Nov 12, 2018
@Reinmar
Copy link
Member Author

Reinmar commented Nov 13, 2018

OK, it seems that webpack 4 may switch to terser as well because they consider this a non-breaking change:

webpack/webpack#8350 (comment)

@ma2ciek
Copy link
Contributor

ma2ciek commented Nov 13, 2018

So after the webpack changes the minifier it might be a good moment to change it too. Maybe terser isn't the best and most stable, but it's actively maintained. - see e.g. the terser/terser#165.

@Reinmar
Copy link
Member Author

Reinmar commented Nov 13, 2018

it's actively maintained.

As I wrote in webpack/webpack#8350 (comment), I'm not worried about today. I'm worried what will be next year :D

@Reinmar Reinmar modified the milestones: nice-to-have, iteration 27 Aug 14, 2019
@Reinmar
Copy link
Member Author

Reinmar commented Aug 14, 2019

It's high time to finally move to terser. Lots of docs to update because we have plenty of uglifyjs-webpack-plugin occurrences.

@mlewand mlewand modified the milestones: iteration 27, iteration 28 Oct 3, 2019
Reinmar added a commit that referenced this issue Nov 26, 2019
Docs: Replaced UglifyJS with Terser. See #1353.
Reinmar added a commit to ckeditor/ckeditor5-build-balloon that referenced this issue Nov 26, 2019
Other: Replaced UglifyJS with Terser. See ckeditor/ckeditor5#1353.
Reinmar added a commit to ckeditor/ckeditor5-build-balloon-block that referenced this issue Nov 26, 2019
Other: Replaced UglifyJS with Terser. See ckeditor/ckeditor5#1353.
Reinmar added a commit to ckeditor/ckeditor5-build-classic that referenced this issue Nov 26, 2019
Other: Replaced UglifyJS with Terser. See ckeditor/ckeditor5#1353.
Reinmar added a commit to ckeditor/ckeditor5-build-decoupled-document that referenced this issue Nov 26, 2019
Other: Replaced UglifyJS with Terser. See ckeditor/ckeditor5#1353.
Reinmar added a commit to ckeditor/ckeditor5-build-inline that referenced this issue Nov 26, 2019
Other: Replaced UglifyJS with Terser. See ckeditor/ckeditor5#1353.
@Reinmar
Copy link
Member Author

Reinmar commented Nov 26, 2019

Followup to review the docs in #5836.

JDinABox pushed a commit to JDinABox/ckeditor5-build-markdown that referenced this issue Sep 6, 2021
Other: Replaced UglifyJS with Terser. See ckeditor/ckeditor5#1353.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
status:discussion type:docs This issue reports a task related to documentation (e.g. an idea for a guide). type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

4 participants