Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Conversion utilities: Docs and tests create model elements using contructor #4271

Closed
scofalik opened this issue Feb 9, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1302
Closed

Conversion utilities: Docs and tests create model elements using contructor #4271

scofalik opened this issue Feb 9, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1302
Assignees
@scofalik
Labels
package:engine type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Milestone
iteration 14

Comments

@scofalik
Copy link
Contributor

scofalik commented Feb 9, 2018

Follow-up to ckeditor/ckeditor5-engine#1274.

In docs and tests we use new ModelElement. We should use writer.createElement instead.
pjasiun referenced this issue in ckeditor/ckeditor5-engine Feb 19, 2018
Merge pull request #1302 from ckeditor/t/1295
809ea24 
Other: Introduced several improvements to conversion helpers. Closes #1295. Closes #1293. Closes #1292. Closes #1291. Closes #1290. Closes #1305.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added module:conversion type:docs This issue reports a task related to documentation (e.g. an idea for a guide). package:engine labels Oct 9, 2019
This was referenced Oct 11, 2019
Merged
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@scofalik scofalik

Labels
package:engine type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Projects
None yet
Milestone
iteration 14
2 participants
@scofalik @mlewand