Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Search doesn't search components, or ingredients in component recipes #36

Open
crosbyh opened this issue Mar 28, 2020 · 2 comments
Open

Comments

@crosbyh
Copy link

crosbyh commented Mar 28, 2020

The search field does not seem to search for component recipes, or ingredients within recipes composed of components.

For example, in the demo instance, if I search "graham" the component for "Graham Cracker Crust" does not surface in results.

If I search "eggs" neither the Vanilla Custard Filling component, nor the Red Berry Tart recipe surface.

I think it would be useful to be able to search for components (maybe I want to use my Graham Cracker Crust for some other type of tart) and to have ingredients within component recipes be searchable. Might this be possible?

@clarklab
Copy link
Owner

Hey! I'll take a look into it. The component recipes never quite took off (for me, at least), but I would like to have them included in search results. Getting the ingredients into search was pretty manual, so I might need to edit the JSON template to get them included.

@ptoulouse
Copy link

As a suggestion, why treat components separatly (with a separate folder)? Taking your red berry tart as an example, the crust is a recipe by itself. You can keep the components which would refer to other recipes instead of components. That would probably fix the search part as well.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants