Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

increase unit test coverage on config.go #413

Closed
jodh-intel opened this issue Aug 11, 2017 · 4 comments
Closed

increase unit test coverage on config.go #413

jodh-intel opened this issue Aug 11, 2017 · 4 comments
Assignees

Comments

@jodh-intel
Copy link
Contributor

Currently very close to 100% (which looks to be achievable).

See #93.

@jodh-intel
Copy link
Contributor Author

I think this just needs 1 more test similar to TestConfigLoadConfigurationFailBrokenSymLink() that creates a valid symlink to an unreadable file which will cause loadConfiguration() to fail.

@jodh-intel
Copy link
Contributor Author

Hi @sboeuf - any update on this?

@sboeuf
Copy link
Contributor

sboeuf commented Aug 30, 2017

@jodh-intel this one is already all covered, isn't it ?

@jodh-intel
Copy link
Contributor Author

Ah - I see what's happened - I raised this issue based on the coveralls output, but at that time coveralls was only running the tests as root. Now that #484 has landed, coveralls now gets to see the tests I actually wrote for config.go on #484 which increased the coverage to 100% when run as a non-root user!

Closing as already done 😄

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants