chore: es6 unmarshaller #108
Conversation
|
I added the suggested changes after you insisted, but they break the build. |
|
You could have made the change locally and easily seen the syntax error and then pushed them. Were you trying to prove a point? I didn't insist. I just suggested. |
The suggested change doesn't just introduce format errors which are easy to fix. It introduces a rogue "catch" statement. I don't understand what we're trying to do. I'm just trying to change the unmarshaller to es6, not change the file in this small PR which might require the tests to change. Can we please approve the PR assuming we will revert the last commit? |
|
There's also an error with a repeated "payload is null or undefined" error. |
grant
force-pushed
the
grant_unmarshal
branch
2 times, most recently
from
46b4bcc to
ea289a2
Compare
|
OK, I fixed the error. The tests now pass locally. |
|
Grant, in a spirit of collaboration, I merely made a suggestion. Your veiled hostility is unwelcome. |
|
OK, I just don't want suggestions of breaking the PR as it was perfectly fine before. There were 2 issues with the suggestion. It's hard enough to make PRs to this repo as is. |
grant
force-pushed
the
grant_unmarshal
branch
2 times, most recently
from
5130527 to
1ef93d6
Compare
|
And yet you continue with the finger pointing. |
|
I'm trying to fix the DCO error, I think the commit from GitHub with the suggested change doesn't isn't signed off and is breaking DCO. |
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com> chore: fix lint multiline if Signed-off-by: Grant Timmerman <timmerman+devrel@google.com> Update lib/bindings/http/unmarshaller.js Co-authored-by: Lance Ball <lball@redhat.com> fix: fix pr suggestion errors Signed-off-by: Grant Timmerman <timmerman+devrel@google.com> refactor: fix DCO in PR Signed-off-by: Grant Timmerman <timmerman+devrel@google.com> fix: fix pr suggestion errors Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
No description provided.