Skip to content

test: use header constants in receiver tests #131

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2020
Merged

test: use header constants in receiver tests #131

merged 1 commit into from
May 7, 2020

Conversation

danbev
Copy link
Contributor

@danbev danbev commented May 6, 2020

Signed-off-by: Daniel Bevenius daniel.bevenius@gmail.com

@danbev
test: use header constants in receiver tests
30ff9fd 
Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
@helio-frota helio-frota self-requested a review May 6, 2020 10:56
lance
lance approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like the destructuring of these constants so that you don't end up using constants.BINARY_HEADERS_03 for example. That'd be a nice optimization for existing usage. :) Thanks for the contrib!

@lance lance added module/transport/http Issues related to the HTTP transport protocol implementation module/test Issues and changes related to the tests labels May 6, 2020
@lance lance merged commit 60bf05c into cloudevents:master May 7, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lance lance lance approved these changes

@helio-frota helio-frota helio-frota approved these changes

Assignees
No one assigned
Labels
module/test Issues and changes related to the tests module/transport/http Issues related to the HTTP transport protocol implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danbev @lance @helio-frota