Skip to content

Add ref to CoC and other things #244

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Add ref to CoC and other things #244

merged 2 commits into from
Aug 11, 2020

Conversation

duglin
Copy link
Contributor

@duglin duglin commented Jul 7, 2020

Wait until cloudevents/spec#663 is resolved.

However, look over the wording and once we get that right I'll open similar PRs in other SDK repos

Signed-off-by: Doug Davis dug@us.ibm.com

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok - just a couple of minor wording suggestions, and a question re: the CoC link.

@lance lance added the module/docs Module documentation changes label Jul 16, 2020
@lance
Copy link
Member

lance commented Aug 10, 2020

@duglin ping - just making sure this doesn't fall off of your radar

Signed-off-by: Doug Davis <dug@us.ibm.com>
Signed-off-by: Doug Davis <dug@us.ibm.com>
@duglin
Copy link
Contributor Author

duglin commented Aug 11, 2020

thanks for the reminder @lance
Give it another look-over....

@lance
Copy link
Member

lance commented Aug 11, 2020

@duglin looks good to me. The title still has this as WIP. Is that the case?

@duglin duglin changed the title [WIP] add ref to CoC and other things Add ref to CoC and other things Aug 11, 2020
@duglin
Copy link
Contributor Author

duglin commented Aug 11, 2020

oops - fixed!

@lance lance merged commit 380a253 into cloudevents:master Aug 11, 2020
lance pushed a commit that referenced this pull request Aug 11, 2020
* add ref to CoC and other things

Signed-off-by: Doug Davis <dug@us.ibm.com>
lance pushed a commit that referenced this pull request Sep 11, 2020
* add ref to CoC and other things

Signed-off-by: Doug Davis <dug@us.ibm.com>
@lholmquist lholmquist mentioned this pull request Dec 11, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
module/docs Module documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants