-
Notifications
You must be signed in to change notification settings - Fork 69
Add ref to CoC and other things #244
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance
reviewed
Jul 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok - just a couple of minor wording suggestions, and a question re: the CoC link.
@duglin ping - just making sure this doesn't fall off of your radar |
Signed-off-by: Doug Davis <dug@us.ibm.com>
Signed-off-by: Doug Davis <dug@us.ibm.com>
thanks for the reminder @lance |
@duglin looks good to me. The title still has this as WIP. Is that the case? |
lance
approved these changes
Aug 11, 2020
oops - fixed! |
lance
pushed a commit
that referenced
this pull request
Aug 11, 2020
* add ref to CoC and other things Signed-off-by: Doug Davis <dug@us.ibm.com>
lance
pushed a commit
that referenced
this pull request
Sep 11, 2020
* add ref to CoC and other things Signed-off-by: Doug Davis <dug@us.ibm.com>
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait until cloudevents/spec#663 is resolved.
However, look over the wording and once we get that right I'll open similar PRs in other SDK repos
Signed-off-by: Doug Davis dug@us.ibm.com