feat: add batch mode #448
Merged
feat: add batch mode #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance
added
type/enhancement
grant
approved these changes
Dec 1, 2021
This is experimental and still a work in progress. Fixes: cloudevents#440 (eventually) Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
lance
force-pushed
the
lance/440-add-batch
branch
from
ee150f2 to
7d5b2ba
Compare
Signed-off-by: Lance Ball <lball@redhat.com>
|
@grant thanks for the earlier review. I have made a few modifications since then, so if you don't mind a second look I would appreciate it. @lholmquist if you've got feedback on this I would welcome it as well. Thanks! |
lholmquist
approved these changes
Dec 7, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is experimental and still a work in progress. Would be interested in thoughts folks have on this - esp things like
HTTP.toEvent(): CloudEvent | CloudEvent[]. The modifications were pretty simple in order to support batch mode, in my opinion. But it might have made some usage clunky, such as that. Marked as a WiP so I can add more tests and the overall design/direction can be hashed out first (if this doesn't look quite right)./cc @cloudevents/sdk-javascript-maintainers
Fixes: #440 (eventually)
Signed-off-by: Lance Ball lball@redhat.com