Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: use es6 for cloudevents.js #73

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Conversation

grant
Copy link
Member

@grant grant commented Apr 29, 2020

No description provided.

@grant grant requested a review from fabiojose April 29, 2020 03:58
@grant grant force-pushed the grant_simplify_cloudeventsjs branch from 75928d6 to c0c5840 Compare April 29, 2020 03:59
@grant
Copy link
Member Author

grant commented Apr 29, 2020

The Travis failure is not due to changes in this PR.

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an incremental improvement but dances around the goal of idiomatic code style. For instance it doesn’t take any steps towards addressing #65. I don’t see harm in landing this but I think some of the larger architectural patterns still need to be dealt with. Moving towards idiomatic code, direct object creation, and immutable instances requires eliminating the setter functions and using class get functions. Personally I think it would be worth exploring that approach.

@grant
Copy link
Member Author

grant commented Apr 29, 2020

Yes, I'd like to get there too, but I don't want to change the whole codebase by renaming methods at this point.

I'd like to merge this incremental improvement and make small PRs. Right now I can't even make simple changes due to Travis configs and DCO checks which makes things painful.

@lance
Copy link
Member

lance commented Apr 29, 2020

@grant you should rebase from master to pull in the Travis-CI code coverage fix. That will re-run the tests and you'll see a successful build.

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant grant force-pushed the grant_simplify_cloudeventsjs branch from c0c5840 to 4a98edc Compare April 29, 2020 19:50
@grant
Copy link
Member Author

grant commented Apr 29, 2020

I think the PR Quality Review tool is actually wrong here. It's saying an object is a block.

@lance
Copy link
Member

lance commented Apr 29, 2020

@grant I agree - the Codacy rule seems broken.

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grant grant merged commit 12ac181 into master Apr 29, 2020
@grant grant deleted the grant_simplify_cloudeventsjs branch April 29, 2020 20:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants