Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix typo on email API settings endpoint #1060

Merged

Conversation

Cyb3r-Jak3
Copy link

Description

The endpoint for enabling Email Routing for a zone is enable and not enabled

Has your change been tested?

Updated unit tests and they pass

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@codecov-commenter
Copy link

Codecov Report

Merging #1060 (4bdba96) into master (e39278e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   49.94%   49.94%           
=======================================
  Files         115      115           
  Lines       10991    10991           
=======================================
  Hits         5490     5490           
  Misses       4338     4338           
  Partials     1163     1163           
Impacted Files Coverage Δ
teams_accounts.go 53.84% <ø> (ø)
email_routing_settings.go 60.00% <100.00%> (ø)
r2_bucket.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

changelog detected ✅

@jacobbednarz jacobbednarz merged commit 91746dd into cloudflare:master Aug 25, 2022
@github-actions github-actions bot added this to the v0.49.0 milestone Aug 25, 2022
@Cyb3r-Jak3 Cyb3r-Jak3 deleted the email-routing-enable-typo branch August 25, 2022 02:59
@github-actions
Copy link

This functionality has been released in v0.49.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants