Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update tunnels #1227

Merged
merged 3 commits into from
Mar 5, 2023
Merged

Update tunnels #1227

merged 3 commits into from
Mar 5, 2023

Conversation

Cyb3r-Jak3
Copy link

Description

  • Updates the tunnels structs to match the current API docs
  • Changes to using ListTunnels and GetTunnel instead of Tunnels and Tunnel.

Has your change been tested?

Existing and updated tests pass.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@Cyb3r-Jak3 Cyb3r-Jak3 requested a review from jacobbednarz as a code owner March 3, 2023 21:41
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

changelog detected ✅

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2023

Codecov Report

Merging #1227 (b762d69) into master (b1a4688) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1227      +/-   ##
==========================================
- Coverage   49.31%   49.31%   -0.01%     
==========================================
  Files         130      130              
  Lines       12555    12556       +1     
==========================================
  Hits         6192     6192              
- Misses       4938     4939       +1     
  Partials     1425     1425              
Impacted Files Coverage Δ
tunnel.go 41.93% <100.00%> (ø)
teams_rules.go 41.66% <0.00%> (-0.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

.changelog/1227.txt Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit e9b402b into cloudflare:master Mar 5, 2023
@jacobbednarz
Copy link
Member

thanks @Cyb3r-Jak3 🥇

@github-actions github-actions bot added this to the v0.63.0 milestone Mar 5, 2023
github-actions bot pushed a commit that referenced this pull request Mar 5, 2023
@Cyb3r-Jak3 Cyb3r-Jak3 deleted the update-tunnels branch March 5, 2023 23:50
@github-actions
Copy link

This functionality has been released in v0.63.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@cloudflare cloudflare locked as resolved and limited conversation to collaborators Mar 14, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants