Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

AUTH-5315 adds new conditional_access_enabled attr to access IDP #1344

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

ghost
Copy link

@ghost ghost commented Aug 1, 2023

Description

  • adds new conditional_access_enabled attr to access IDP
  • list/put IDP auth context endpoints
  • auth context rule type

Has your change been tested?

  • Added unit tests for policy creation w/new rule and auth context endpoints

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@ghost ghost requested a review from jacobbednarz as a code owner August 1, 2023 14:41
@ghost ghost changed the title AUTH-5315 adds new conditional_access_enabled attr to access IDP, aut… AUTH-5315 adds new conditional_access_enabled attr to access IDP Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

changelog detected ✅

@codecov-commenter
Copy link

Codecov Report

Merging #1344 (6ae3c54) into master (b9ac804) will increase coverage by 0.18%.
Report is 92 commits behind head on master.
The diff coverage is 60.23%.

@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
+ Coverage   48.33%   48.52%   +0.18%     
==========================================
  Files         133      135       +2     
  Lines       13023    13234     +211     
==========================================
+ Hits         6295     6422     +127     
- Misses       5201     5256      +55     
- Partials     1527     1556      +29     
Files Changed Coverage Δ
access_group.go 70.00% <ø> (ø)
device_posture_rule.go 61.80% <ø> (ø)
load_balancing.go 59.40% <ø> (ø)
teams_accounts.go 53.84% <ø> (ø)
regional_tiered_cache.go 43.75% <43.75%> (ø)
logpush.go 51.81% <46.15%> (-0.30%) ⬇️
images.go 44.70% <47.82%> (-0.12%) ⬇️
rulesets.go 30.03% <52.17%> (-4.61%) ⬇️
access_identity_provider.go 65.11% <61.29%> (-1.22%) ⬇️
pages_deployment.go 38.88% <61.76%> (+4.64%) ⬆️
... and 5 more

... and 3 files with indirect coverage changes

Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once we have public docs 🚀

@jacobbednarz jacobbednarz merged commit 0fb602f into cloudflare:master Aug 15, 2023
@github-actions github-actions bot added this to the v0.75.0 milestone Aug 15, 2023
github-actions bot pushed a commit that referenced this pull request Aug 15, 2023
@github-actions
Copy link

This functionality has been released in v0.75.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants