Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DLP-1479: made DLP ContextAwareness a pointer #1510

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

MattDavis00
Copy link

Description

This is to allow for easier optionality checks with == nil

The parent context_awareness property is optional, if it is defined then all of the children are required.

https://developers.cloudflare.com/api/operations/dlp-profiles-update-predefined-profile

Has your change been tested?

Yes. Changed unit test to account for ContextAwareness being optional.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link

github-actions bot commented Mar 1, 2024

changelog detected ✅

This is to allow for easier optionality checks with == nil

The parent context_awareness property is optional, if it is defined
then all of the children are required.

https://developers.cloudflare.com/api/operations/dlp-profiles-update-predefined-profile

Signed-off-by: Matt Davis <mattdavis@cloudflare.com>
@jacobbednarz jacobbednarz merged commit 7789ba8 into cloudflare:master Mar 4, 2024
10 checks passed
@github-actions github-actions bot added this to the v0.90.0 milestone Mar 4, 2024
github-actions bot pushed a commit that referenced this pull request Mar 4, 2024
Copy link

This functionality has been released in v0.90.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants