Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add flag to skip the app launcher landing pg #2793

Conversation

sha-e-256
Copy link

@sha-e-256 sha-e-256 commented Jul 29, 2024

Description

A new flag, skip_app_launcher_login_page, is now available which can be toggled to skip the App Launcher landing page a.k.a. the page that is shown to users when they visit their auth. domain i.e. <team>.cloudflareaccess.com.

This flag is documented for an app of the type App Launcher App at https://developers.cloudflare.com/api/operations/access-applications-add-an-application:

image

This flag is a part of Access and is an App Launcher customization property.

Has your change been tested?

The unit test to test the creation of an App Launcher application has been updated to include the skip_app_launcher_login_page flag.

Screenshots (if appropriate):

Screenshots N/A.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link

github-actions bot commented Jul 29, 2024

changelog detected ✅

access_application.go Outdated Show resolved Hide resolved
@sha-e-256 sha-e-256 marked this pull request as ready for review July 29, 2024 15:32
@sha-e-256 sha-e-256 requested a review from jacobbednarz as a code owner July 29, 2024 15:32
@sha-e-256 sha-e-256 force-pushed the add-flag-to-skip-app-launcher-landing-pg branch from 1373175 to ec51561 Compare July 30, 2024 14:27
.changelog/2793.txt Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit ccae552 into cloudflare:master Jul 31, 2024
9 checks passed
@github-actions github-actions bot added this to the v0.101.0 milestone Jul 31, 2024
Copy link

This functionality has been released in v0.101.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants