From a671f25b50372f11c96e8b182f18881fc9c666b3 Mon Sep 17 00:00:00 2001 From: Nicholas Paun Date: Fri, 16 Aug 2024 10:12:55 -0700 Subject: [PATCH] Do not allow code with warnings to pass CI --- .bazelrc | 1 + .github/workflows/test.yml | 3 +++ 2 files changed, 4 insertions(+) diff --git a/.bazelrc b/.bazelrc index 510ccdc5b6ed..ef0206c6dc21 100644 --- a/.bazelrc +++ b/.bazelrc @@ -43,6 +43,7 @@ build --@dawn//src/tint:tint_build_wgsl_writer=True # Our dependencies (ICU, zlib, etc.) produce a lot of these warnings, so we disable them. Depending # on the clang version, zlib either produces warnings for -Wdeprecated-non-prototype or does not # have that option, so disable -Wunknown-warning-option there too. +build --per_file_copt='external/@-Wno-error' build --per_file_copt='external/v8@-Wno-deprecated-declarations' build --per_file_copt='external/com_googlesource_chromium_icu@-Wno-ambiguous-reversed-operator,-Wno-deprecated-declarations' build --host_per_file_copt='external/com_googlesource_chromium_icu@-Wno-ambiguous-reversed-operator,-Wno-deprecated-declarations' diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 155acaafce73..caca5837589f 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -84,6 +84,9 @@ jobs: sudo apt-get install -y --no-install-recommends clang-16 lld-16 libunwind-16 libc++abi1-16 libc++1-16 libc++-16-dev libclang-rt-16-dev echo "build:linux --action_env=CC=/usr/lib/llvm-16/bin/clang --action_env=CXX=/usr/lib/llvm-16/bin/clang++" >> .bazelrc echo "build:linux --host_action_env=CC=/usr/lib/llvm-16/bin/clang --host_action_env=CXX=/usr/lib/llvm-16/bin/clang++" >> .bazelrc + echo "build:linux --copt='-Werror'" >> .bazelrc + echo "build:linux --copt='-Wno-error=#warnings'" >> .bazelrc + echo "build:linux --copt='-Wno-error=deprecated-declarations'" >> .bazelrc sed -i -e "s%llvm-symbolizer%/usr/lib/llvm-16/bin/llvm-symbolizer%" .bazelrc - name: Setup macOS if: matrix.os.name == 'macOS'