Skip to content

Commit a685f62

Browse files
committed
support to setting tags in which the manifest file
1 parent d11cebe commit a685f62

File tree

3 files changed

+18
-25
lines changed

3 files changed

+18
-25
lines changed

src/bosh-alicloud-cpi/action/create_vm.go

-15
Original file line numberDiff line numberDiff line change
@@ -224,21 +224,6 @@ func (a CreateVMMethod) createVM(
224224
Value: fmt.Sprint(v),
225225
})
226226
}
227-
// 如果没有拿到系统tag,那么为了支持CR,此处需要显示设置上系统Tag
228-
if len(tags) < 1 {
229-
preDefineTags := map[string]string{
230-
"deployment": "bosh",
231-
"director":"bosh-init",
232-
"instance_group":"bosh",
233-
"job":"bosh",
234-
}
235-
for key, value := range preDefineTags {
236-
tags = append(tags, ecs.CreateInstanceTag{
237-
Key: key,
238-
Value: value,
239-
})
240-
}
241-
}
242227
// 接下来获取manifest中的tag
243228
for k, v := range instProps.Tags {
244229
tags = append(tags, ecs.CreateInstanceTag{

src/bosh-alicloud-cpi/action/set_disk_metadata.go

+9-5
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,15 @@ func (a SetDiskMetadataMethod) SetDiskMetadata(diskCID apiv1.DiskCID, meta apiv1
3030

3131
tags := make(map[string]string)
3232
for k, v := range md {
33-
if k == "deployment" || k == "director" || k == "index" || k == "instance_group" || k == "job" {
34-
tk := normalizeTag(k)
35-
if tk != "" {
36-
tags[tk] = normalizeTag(v.(string))
37-
}
33+
// There should support manifest tags feature: https://bosh.io/docs/manifest-v2/#tags
34+
//if k == "deployment" || k == "director" || k == "index" || k == "instance_group" || k == "job" {
35+
// tk := normalizeTag(k)
36+
// if tk != "" {
37+
// tags[tk] = normalizeTag(v.(string))
38+
// }
39+
//}
40+
if normalizeTag(k) != "" {
41+
tags[normalizeTag(k)] = normalizeTag(v.(string))
3842
}
3943
}
4044

src/bosh-alicloud-cpi/action/set_vm_metadata.go

+9-5
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,15 @@ func (a SetVMMetadataMethod) SetVMMetadata(vmCID apiv1.VMCID, meta apiv1.VMMeta)
3535
for k, v := range md {
3636
if k == "name" {
3737
name = normalizeName(v.(string), "i_")
38-
} else if k == "deployment" || k == "director" || k == "index" || k == "instance_group" || k == "job" {
39-
tk := normalizeTag(k)
40-
if tk != "" {
41-
tags[tk] = normalizeTag(v.(string))
42-
}
38+
}
39+
// There should support manifest tags feature: https://bosh.io/docs/manifest-v2/#tags
40+
//} else if k == "deployment" || k == "director" || k == "index" || k == "instance_group" || k == "job" {
41+
// tk := normalizeTag(k)
42+
// if tk != "" {
43+
// tags[tk] = normalizeTag(v.(string))
44+
// }
45+
if normalizeTag(k) != "" {
46+
tags[normalizeTag(k)] = normalizeTag(v.(string))
4347
}
4448
}
4549

0 commit comments

Comments
 (0)