Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Test failure logging for uploads #58

Closed
colbyfayock opened this issue Aug 31, 2023 · 3 comments · Fixed by #72
Closed

Test failure logging for uploads #58

colbyfayock opened this issue Aug 31, 2023 · 3 comments · Fixed by #72
Assignees
@matiasfha
Labels
released

Comments

@colbyfayock
Copy link
Collaborator

Potential cases:

  • Referencing an image that isn't a Cloudinary-supported file (if the node uploader fails)
  • Restricting a remote URL from being downloaded through the node uploader (if this is possible)
@colbyfayock colbyfayock changed the title [Feature] Test failure logging for uploads Test failure logging for uploads Aug 31, 2023
@matiasfha matiasfha self-assigned this Sep 11, 2023
@matiasfha matiasfha mentioned this issue Sep 15, 2023
Merged
11 tasks
@matiasfha
Copy link
Contributor

@colbyfayock When you say

Restricting a remote URL from being downloaded through the node uploader (if this is possible)

You mean checking if when it will be about to upload (here] Since it is a remote URL, halt/throw and log?

@colbyfayock
Copy link
Collaborator Author

@matiasfha no - the idea was to potentially lock down the allowed referrers of the asset so that when trying to download it its not allowed. idk if this would work in practice, but trying to think of ways that the uploader itself will throw the error as thats what we're trying to test

colbyfayock pushed a commit that referenced this issue Oct 4, 2023
@matiasfha
feat: throw and catch error when calls to cloudinary upload fails (#72)
c90c46f 
# Description

<!-- Include a summary of the change made and also list the dependencies
that are required if any -->
Catch errors when using cloudinary uploader. Throw in the lib catch
during build and log them .

## Issue Ticket Number
Fixed #58 

![CleanShot 2023-09-21 at 11 40
00](https://github.com/cloudinary-community/netlify-plugin-cloudinary/assets/282006/07980b15-6e67-4cce-a54a-893169c0daab)

## Type of change

<!-- Please select all options that are applicable. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update


# Checklist

<!-- These must all be followed and checked. -->

- [X] I have followed the contributing guidelines of this project as
mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md)
- [X] I have created an
[issue](https://github.com/colbyfayock/netlify-plugin-cloudinary/issues)
ticket for this PR
- [X] I have checked to ensure there aren't other open [Pull
Requests](https://github.com/colbyfayock/netlify-plugin-cloudinary/pulls)
for the same update/change?
- [X] I have performed a self-review of my own code
- [X] I have run tests locally to ensure they all pass
- [X] I have commented my code, particularly in hard-to-understand areas
- [X] I have made corresponding changes needed to the documentation
github-actions bot pushed a commit that referenced this issue Oct 4, 2023
@semantic-release-bot
chore(release): 1.12.0 [skip ci]
f4676de 
# [1.12.0](v1.11.0...v1.12.0) (2023-10-04)

### Features

* throw and catch error when calls to cloudinary upload fails ([#72](#72)) ([c90c46f](c90c46f)), closes [#58](#58)
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

🎉 This issue has been resolved in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@matiasfha matiasfha

Labels
released
Projects
None yet
Milestone
No milestone
2 participants
@matiasfha @colbyfayock