Replace deprecated parameter for aws_eip resource #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevcube @nitrocode I know this module is deprecated, but we still have a few places where we are using in and switching to https://github.com/cloudposse/terraform-aws-dynamic-subnets would be a bigger lift for us right now. |
|
/terratest |
|
@kevcube Anything else needed here? It doesn't look like the tests are running. |
|
/terratest |
|
It looks like the outputs test is picking up |
If you fix I'll review in the morning |
auto-merge was automatically disabled
September 17, 2024 23:24
Head branch was pushed to by a user without write access
|
/terratest |
1 similar comment
|
/terratest |
kevcube
previously approved these changes
Sep 18, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Replace deprecated
with
for
aws_eipresource.