Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TemplateGenerator emits TypeError when importing bools that should be strings #1044

Closed
chriswgerber opened this issue May 14, 2018 · 3 comments

Comments

@chriswgerber
Copy link

Gist: https://gist.github.com/ThatGerber/1fdb34ca4d293f8c34c1fbca09c5252f

This same error affects other resources like troposphere.ecs.Environment https://github.com/cloudtools/troposphere/blob/master/troposphere/ecs.py#L105 where the value being imported can be any type, but should be cast as String. The Json/Yaml marshaller attempts to determine the type of each object when creating the object, and the TemplateGenerator requires them to be passed in a certain way.

@markpeek
Copy link
Member

@ThatGerber I just created a PR that seems to resolve your gist. Please check it out.

@chriswgerber
Copy link
Author

I’ll try to install and take a look tonight.

@chriswgerber
Copy link
Author

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants