From 528c957002bed07f84abfc475106cfb71a178c48 Mon Sep 17 00:00:00 2001 From: Pat Myron Date: Tue, 18 Aug 2020 20:00:33 -0700 Subject: [PATCH] AWS::KinesisFirehose::DeliveryStream BufferingHints and CompressionFormat not required in S3DestinationConfigurations fixes https://github.com/cloudtools/troposphere/issues/1753 https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-kinesisfirehose-deliverystream-extendeds3destinationconfiguration.html https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-kinesisfirehose-deliverystream-s3destinationconfiguration.html --- troposphere/firehose.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/troposphere/firehose.py b/troposphere/firehose.py index bb256d590..1b9af02f5 100644 --- a/troposphere/firehose.py +++ b/troposphere/firehose.py @@ -164,9 +164,9 @@ class RedshiftDestinationConfiguration(AWSProperty): class S3DestinationConfiguration(AWSProperty): props = { 'BucketARN': (basestring, True), - 'BufferingHints': (BufferingHints, True), + 'BufferingHints': (BufferingHints, False), 'CloudWatchLoggingOptions': (CloudWatchLoggingOptions, False), - 'CompressionFormat': (basestring, True), + 'CompressionFormat': (basestring, False), 'EncryptionConfiguration': (EncryptionConfiguration, False), 'ErrorOutputPrefix': (basestring, False), 'Prefix': (basestring, False), @@ -263,9 +263,9 @@ class DataFormatConversionConfiguration(AWSProperty): class ExtendedS3DestinationConfiguration(AWSProperty): props = { 'BucketARN': (basestring, True), - 'BufferingHints': (BufferingHints, True), + 'BufferingHints': (BufferingHints, False), 'CloudWatchLoggingOptions': (CloudWatchLoggingOptions, False), - 'CompressionFormat': (basestring, True), + 'CompressionFormat': (basestring, False), 'DataFormatConversionConfiguration': (DataFormatConversionConfiguration, False), 'EncryptionConfiguration': (EncryptionConfiguration, False),