feat: timed function for metrics (#1228)

Author: dinhani-cw

Cargo.toml

@@ -84,7 +84,7 @@ tower = "=0.4.13"
 
 # observability
 console-subscriber = "=0.2.0"
-metrics = { version = "=0.23.0", optional = true }
+metrics = "=0.23.0"
 metrics-exporter-prometheus = { version = "=0.15.0", optional = true }
 opentelemetry = "=0.23.0"
 opentelemetry_sdk = { version = "=0.23.0", features = ["rt-tokio"] }
@@ -187,7 +187,7 @@ default = ["bg-threads", "metrics", "tracing", "rocks"]
 dev  = []
 
 # Enable runtime metrics collection.
-metrics = ["dep:metrics", "dep:metrics-exporter-prometheus"]
+metrics = ["dep:metrics-exporter-prometheus"]
 
 # Enable runtime tracing/spans collection.
 tracing = []

src/eth/primitives/storage_point_in_time.rs

@@ -1,5 +1,4 @@
 use crate::eth::primitives::BlockNumber;
-#[cfg(feature = "metrics")]
 use crate::infra::metrics::MetricLabelValue;
 
 /// EVM storage point-in-time indicator.
@@ -18,7 +17,6 @@ pub enum StoragePointInTime {
 // -----------------------------------------------------------------------------
 // Conversions: Self -> Other
 // -----------------------------------------------------------------------------
-#[cfg(feature = "metrics")]
 impl From<&StoragePointInTime> for MetricLabelValue {
     fn from(value: &StoragePointInTime) -> Self {
         match value {

src/eth/storage/rocks/rocks_config.rs

@@ -33,9 +33,10 @@ impl DbConfig {
 
         // NOTE: As per the rocks db wiki: "The overhead of statistics is usually small but non-negligible. We usually observe an overhead of 5%-10%."
         #[cfg(feature = "metrics")]
-        opts.enable_statistics();
-        #[cfg(feature = "metrics")]
-        opts.set_statistics_level(rocksdb::statistics::StatsLevel::ExceptTimeForMutex);
+        {
+            opts.enable_statistics();
+            opts.set_statistics_level(rocksdb::statistics::StatsLevel::ExceptTimeForMutex);
+        }
 
         match self {
             DbConfig::LargeSSTFiles => {