fix: update jsonrpsee to track active requests correctly (#1749)

dinhani-cw · web-flow · commit 4a72d553e2a1 · 2024-10-07T16:30:19.000-03:00
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -76,7 +76,7 @@ rlp = "=0.5.2"
 triehash = "=0.8.4"
 
 # network
-jsonrpsee = { version = "=0.24.5", features = ["server", "client"] }
+jsonrpsee = { version = "=0.24.6", features = ["server", "client"] }
 reqwest = { version = "=0.12.4", features = ["json"] }
 tonic = "=0.11.0"
 tower = "=0.4.13"
diff --git a/src/eth/rpc/rpc_middleware.rs b/src/eth/rpc/rpc_middleware.rs
@@ -122,7 +122,7 @@ impl<'a> RpcServiceT<'a> for RpcMiddleware {
 
             // active requests
             if let Some(guard) = request.extensions.get::<ConnectionGuard>() {
-                let active = guard.max_connections() - guard.available_connections(); // TODO: wait for this to be fixed https://github.com/paritytech/jsonrpsee/issues/1467
+                let active = guard.max_connections() - guard.available_connections();
                 metrics::set_rpc_requests_active(active as u64);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ impl<'a> RpcServiceT<'a> for RpcMiddleware {`
`122`	`122`
`123`	`123`	`// active requests`
`124`	`124`	`if let Some(guard) = request.extensions.get::<ConnectionGuard>() {`
`125`		`- let active = guard.max_connections() - guard.available_connections(); // TODO: wait for this to be fixed https://github.com/paritytech/jsonrpsee/issues/1467`
	`125`	`+ let active = guard.max_connections() - guard.available_connections();`
`126`	`126`	`metrics::set_rpc_requests_active(active as u64);`
`127`	`127`	`}`
`128`	`128`	`}`