Skip to content

Commit b780cbd

Browse files
fix(importer): simplify block processing and error handling
Streamline block import process by: - Removing redundant error handling for pending block - Directly calling `finish_pending_block()` with error propagation - Adding explicit `set_mined_block_number()` after block save - Removing unnecessary logging for pending block errors
1 parent 39d6007 commit b780cbd

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

src/eth/follower/importer/importer.rs

+4-12
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ impl Importer {
199199

200200
let block_number = block.number();
201201
let mined_number = storage.read_mined_block_number()?;
202-
202+
203203
if block_number != mined_number.next_block_number() {
204204
tracing::error!(
205205
block_number = %block_number,
@@ -208,18 +208,10 @@ impl Importer {
208208
);
209209
continue;
210210
}
211-
212-
// Try to finish any pending block first
213-
if let Err(e) = storage.finish_pending_block() {
214-
tracing::error!(
215-
reason = ?e,
216-
block_number = %block_number,
217-
"failed to finish pending block"
218-
);
219-
continue;
220-
}
221-
211+
212+
storage.finish_pending_block()?;
222213
storage.save_block(block)?;
214+
storage.set_mined_block_number(block_number)?;
223215
}
224216
Ok(())
225217
}

0 commit comments

Comments
 (0)