Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

hg_prompt_filter @ clink.lua is broken #1978

Closed
Sairony opened this issue Dec 5, 2018 · 1 comment
Closed

hg_prompt_filter @ clink.lua is broken #1978

Sairony opened this issue Dec 5, 2018 · 1 comment

Comments

@Sairony
Copy link

Sairony commented Dec 5, 2018

It seems to operate under the assumption that hg id will return at the very least 2 lines. However in a repo on default with no tags or bookmarks with uncommitted changes it will return only a single line, items will then contain only 1 item, and hence result = color .. items[2] -- string.sub(items[2], 1, string.len(items[2]) - 1) on line 339 will index out of bounds & try to concat with a nil value. Or at the very least that's my understanding with poor lua skills. The consequence is cmder\vendor/clink.lua:339: attempt to concatenate field '?' (a nil value) after every command while inside the repo.

@Shingyx
Copy link

Shingyx commented Jan 8, 2019

This should be fixed by #2002

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants