[Feature] Allow to specify deployment order in cnfs that have multiple deployments #2176
Labels
enhancement
New feature or request
Comments
svteb
added a commit
that referenced
this issue
Nov 12, 2024
Refs: #2168 - New setup spec tests were introduced to verify that the installation method from #2161 works as intended. - Three distinct issues were discovered and resolved: * Helm directories with variable depth levels could not be discovered after initialization (resolved through File.basename). * Configs that weren't named cnf-testsuite.yml could not be discovered after initialization (resolved by changing the name internally when copying the file). * Existence of manifest folder was not checked (resolved by adding an if check). - Additionally a common point of failure was added with a failure message that was previously not present. - The issue #2176 was also discovered during attempted deployment of sample-cnfs/sample-elk-stack which was also added in this commit and is to be used in future spec test. Signed-off-by: svteb <slavo.valko@tietoevry.com>
20 tasks
svteb
added a commit
that referenced
this issue
Nov 13, 2024
Refs: #2168 - New setup spec tests were introduced to verify that the installation method from #2161 works as intended. - Three distinct issues were discovered and resolved: * Helm directories with variable depth levels could not be discovered after initialization (resolved through File.basename). * Configs that weren't named cnf-testsuite.yml could not be discovered after initialization (resolved by changing the name internally when copying the file). * Existence of manifest folder was not checked (resolved by adding an if check). - Additionally a common point of failure was added with a failure message that was previously not present. - The issue #2176 was also discovered during attempted deployment of sample-cnfs/sample-elk-stack which was also added in this commit and is to be used in future spec test. Signed-off-by: svteb <slavo.valko@tietoevry.com>
svteb
added a commit
that referenced
this issue
Nov 14, 2024
Refs: #2168 - New setup spec tests were introduced to verify that the installation method from #2161 works as intended. - Three distinct issues were discovered and resolved: * Helm directories with variable depth levels could not be discovered after initialization (resolved through File.basename). * Configs that weren't named cnf-testsuite.yml could not be discovered after initialization (resolved by changing the name internally when copying the file). * Existence of manifest folder was not checked (resolved by adding an if check). - Additionally a common point of failure was added with a failure message that was previously not present. - The issue #2176 was also discovered during attempted deployment of sample-cnfs/sample-elk-stack which was also added in this commit and is to be used in future spec test. Signed-off-by: svteb <slavo.valko@tietoevry.com>
kosstennbl
pushed a commit
that referenced
this issue
Nov 22, 2024
Add installation_priority parameter for specification of order for installation of deployments. Refs: #2176 Signed-off-by: Konstantin Yarovoy <konstantin.yarovoy@tietoevry.com>
collivier
pushed a commit
that referenced
this issue
Nov 27, 2024
Refs: #2168 - New setup spec tests were introduced to verify that the installation method from #2161 works as intended. - Three distinct issues were discovered and resolved: * Helm directories with variable depth levels could not be discovered after initialization (resolved through File.basename). * Configs that weren't named cnf-testsuite.yml could not be discovered after initialization (resolved by changing the name internally when copying the file). * Existence of manifest folder was not checked (resolved by adding an if check). - Additionally a common point of failure was added with a failure message that was previously not present. - The issue #2176 was also discovered during attempted deployment of sample-cnfs/sample-elk-stack which was also added in this commit and is to be used in future spec test. Signed-off-by: svteb <slavo.valko@tietoevry.com>
svteb
added a commit
that referenced
this issue
Nov 28, 2024
Refs: #2168 - New setup spec tests were introduced to verify that the installation method from #2161 works as intended. - Three distinct issues were discovered and resolved: * Helm directories with variable depth levels could not be discovered after initialization (resolved through File.basename). * Configs that weren't named cnf-testsuite.yml could not be discovered after initialization (resolved by changing the name internally when copying the file). * Existence of manifest folder was not checked (resolved by adding an if check). - Additionally a common point of failure was added with a failure message that was previously not present. - The issue #2176 was also discovered during attempted deployment of sample-cnfs/sample-elk-stack which was also added in this commit and is to be used in future spec test. Signed-off-by: svteb <slavo.valko@tietoevry.com>
kosstennbl
pushed a commit
that referenced
this issue
Nov 29, 2024
Add installation_priority parameter for specification of order for installation of deployments. Refs: #2176 Signed-off-by: Konstantin Yarovoy <konstantin.yarovoy@tietoevry.com>
kosstennbl
pushed a commit
that referenced
this issue
Dec 3, 2024
Add installation_priority parameter for specification of order for installation of deployments. Refs: #2176 Signed-off-by: Konstantin Yarovoy <konstantin.yarovoy@tietoevry.com>
svteb
pushed a commit
that referenced
this issue
Dec 18, 2024
Refs: #2176 Add installation_priority parameter for specification of order for installation of deployments. Signed-off-by: Konstantin Yarovoy <konstantin.yarovoy@tietoevry.com>
svteb
pushed a commit
that referenced
this issue
Dec 18, 2024
Refs: #2176 Add installation_priority parameter for specification of order for installation of deployments. Signed-off-by: Konstantin Yarovoy <konstantin.yarovoy@tietoevry.com>
svteb
pushed a commit
that referenced
this issue
Dec 18, 2024
Refs: #2176 Add installation_priority parameter for specification of order for installation of deployments. Signed-off-by: Konstantin Yarovoy <konstantin.yarovoy@tietoevry.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Is your feature request related to a problem? Please describe.
During testing of the new installation method introduced in #2165 I noticed that some cnfs might fail to setup/cleanup properly if they are installed/uninstalled in the incorrect order. This happened specifically with elk stack deployment, where a post-delete kibana pod was stuck in CreatingContainer state because elasticsearch was deleted before kibana.
Describe the solution you'd like
We should add an optional tag to config with the install order, unless I am mistaken the uninstall order should then just be the install order but reversed to get the proper result.
How will this be tested? aka Acceptance Criteria (optional)
Add a new a spec test that will verify this (there is an elk stack sample already).
The text was updated successfully, but these errors were encountered: