Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

amf: Change amf_pod_name to amf_service_name #1863

Merged
merged 1 commit into from
Jan 31, 2024
Merged

amf: Change amf_pod_name to amf_service_name #1863

merged 1 commit into from
Jan 31, 2024

Conversation

horecoli
Copy link
Contributor

Description

This change updates pod to service in Open5gs configuration and samples.

Issues:

Refs: #1860

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. rescue block

Issue

  • Tasks in issue are checked off

@horecoli
amf: Change amf_pod_name to amf_service_name
4506945 
This change updates pod to service in Open5gs
configuration and samples.

Closes-Bug: cnti-testcatalog#1860
Signed-off-by: horecoli <oliver.horecny@tietoevry.com>
agentpoyo
agentpoyo approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@agentpoyo agentpoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agentpoyo agentpoyo merged commit 463be6d into cnti-testcatalog:main Jan 31, 2024
16 of 95 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@agentpoyo agentpoyo agentpoyo approved these changes

@denverwilliams denverwilliams Awaiting requested review from denverwilliams denverwilliams is a code owner

@wvwatson wvwatson Awaiting requested review from wvwatson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@horecoli @agentpoyo